synchrony / smsn

Semantic Synchrony. An experiment in cognitive and sensory augmentation.
Other
178 stars 15 forks source link

Make getConfiguration serialization more robust #69

Open jmatsushita opened 1 year ago

jmatsushita commented 1 year ago

In order to avoid this bug to reappear on a future dependency update that would revert https://github.com/synchrony/smsn/pull/68 , it would be good to:

joshsh commented 1 year ago

Note: assigned to self, but I may leave this issue idle for now, as I expect that I/O will be revamped before there is any need to bump the JSON dependency.

joshsh commented 1 year ago

...unless the bad configuration is occurring during ordinary operation, in which case merely tolerating it does not seem like the right thing to do. What are the minimal steps to reproduce the error condition?

jmatsushita commented 1 year ago

I may leave this issue idle for now, as I expect that I/O will be revamped before there is any need to bump the JSON dependency.

Sounds very reasonable.

What are the minimal steps to reproduce the error condition?

I don't have a clear path to reproduction, but I suspect that starting with a fresh gremlin/neo4j install with empty sources folder would yield the same error. In order to make this reproducible, I would probably go towards a more declarative installation process, either by upgrading the docker approach (which used to be my goto), or moving towards a nix-based approach (which is my current preferred approach with https://devenv.sh/).

I think it's a good idea to go this route as this also means it would open the path to setting up CI (with github actions for example) which would be useful if there's some level of contribution in the repo.