syncloud / platform

Run popular services on your device with one click
https://syncloud.org
GNU General Public License v3.0
401 stars 40 forks source link

No message for unsupported file systems #169

Closed vsapronov closed 8 years ago

vsapronov commented 8 years ago

Rest resturns server error 500.

This is in the log: root@odroid-xu3and4:/opt/data/platform/log# tail uwsgi_public.log File "/opt/app/platform/python/lib/python2.7/site-packages/syncloud_platform-936-py2.7.egg/syncloud_platform/rest/public.py", line 196, in disk_activate return jsonify(success=True, disks=public.disk_activate(request.args['device'])), 200 File "/opt/app/platform/python/lib/python2.7/site-packages/syncloud_platform-936-py2.7.egg/syncloud_platform/rest/facade/public.py", line 75, in disk_activate return self.hardware.activate_disk(device) File "/opt/app/platform/python/lib/python2.7/site-packages/syncloud_platform-936-py2.7.egg/syncloud_platform/disks/hardware.py", line 48, in activate_disk raise Exception(error_message) Exception: Filesystem type is not supported: ntfs, use on of the following: ['ext4', 'ext3', 'ext2']

cyberb commented 8 years ago

We should probably make this return 200 as this is application level exception (success = false) and not transport. https://github.com/syncloud/platform/blob/master/src/syncloud_platform/rest/public.py#L244

Is this what you want?