syncloud / platform

Run popular services on your device with one click
https://syncloud.org
GNU General Public License v3.0
400 stars 40 forks source link

Reorganize and add app info #508

Closed klmhsb42 closed 4 years ago

klmhsb42 commented 4 years ago

This is how I would organize and add app info. #412 What do you think? From where does it get <%= info.app.description %> I would like to add content.

cyberb commented 4 years ago

app info actually comes from snap syncloud store info: https://github.com/syncloud/snapd/blob/release-2.43/store/syncloud.go#L101

which comes from here: https://github.com/syncloud/release/blob/master/index-v2

Probably description does not work right now.

cyberb commented 4 years ago

Do you have a screenshot for this change? Actually if your run drone locally you will get all the screenshots in artifact sir.

klmhsb42 commented 4 years ago

screenshot screenshot2

klmhsb42 commented 4 years ago

Probably description does not work right now.

Yes

app info actually comes from snap syncloud store info: https://github.com/syncloud/snapd/blob/release-2.43/store/syncloud.go#L101

Probably because "description" is missing here.

klmhsb42 commented 4 years ago

I would put all description and detail information in an own popup as details might be confusing for non-technicals and if the upgrade button appears, everybody still knows what to do. I would also add more details like licence, channel, etc. (Some information you have already in syncloud.go file.)

klmhsb42 commented 4 years ago

(It would be nice to have later a second button, which is a star, which would also open an own popup window, in which you can rate/comment the app.)

cyberb commented 4 years ago

Should we close this pull request as it is not ready?

klmhsb42 commented 4 years ago

Yes