Add dotted notes and make tests work cross-platform

syncopika / mmp-to-MusicXML

convert LMMS mmp files to MusicXML

https://syncopika.github.io/mmp-to-MusicXML/

5 stars 2 forks source link

Add dotted notes and make tests work cross-platform #12

Closed syncopika closed 1 month ago

syncopika commented 1 month ago

finally added support for some dotted notes! (eighth, quarter, half) :D
fixed tests so they should work also on Linux and not just Windows
some minor edits including fixing some variable names for consistency style-wise and closing the musicxml file being written to 😬

nicolai-rostov commented 1 month ago

Dear @syncopika,

Thanks for having added support to dotted notes, and fixed the path issue in the tests. I've justed updated the master branch in my fork, and everything looks good.

We need to talk. Can I reach you using your outlook.com email address?

Thanks

syncopika commented 1 month ago

hey @nicolai-rostov,

awesome, thank you for letting me know!

and yep, you can reach out to me via my outlook email. thanks for asking!