search

syncromatics / syncromatics-track-api

Library to interact with the Syncromatics Track API
https://www.npmjs.com/package/syncromatics-track-api
6 stars 1 forks source link

fix(dispatch_messages): Rename route property to pattern #41

Closed cuevaskoch closed 6 years ago

cuevaskoch commented 6 years ago

BREAKING CHANGE: Removed Dispatch Message's Route property. This property actually referred to Patterns and has been updated accordingly.

kennethito commented 6 years ago

Just curious on how we manage breaking changes. Do we communicate out to integrators? Does the server actually support either route or pattern for X amount of time?

thzinc commented 6 years ago

@kennethito, in this case, integrators manage it via semver and semantic-release. (Although I see we haven't tagged a version 1.0.0 yet, so we're just ticking up our minor version number at the moment.)

cuevaskoch commented 6 years ago

Whoops, will that commit message trigger a bump in major version even though we haven't hit 1.0.0 yet? i'll check Travis logs

kennethito commented 6 years ago

@thzinc So the server will still handle the old clients?

thzinc commented 6 years ago

@kennethito oh, I see what you mean. No, in this case, the breaking change would break old clients, but we're reasonably sure that no one else has integrated with the dispatch messages functionality that was very recently deployed.

kennethito commented 6 years ago

Ah, gotcha.