search

syncthing / apt-web

The web component of http://apt.syncthing.net/
11 stars 18 forks source link

Instructions pulled in Debian's syncthing instead of Syncthing's syncthing #13

Closed genpfault closed 5 years ago

genpfault commented 6 years ago

Just tried the instructions on the landing page and the final install command:

sudo apt-get install syncthing

...pulled in Debian's 0.14.51+ds2-3 instead of Syncthing's 0.14.51. I guess because Debian's version is "greater" somehow? Unfortunately Debian's version has broken icon fonts :(

Using -t syncthing pulled in the correct version and fixed the font issue for me:

sudo apt-get install -t syncthing syncthing

Syncthing Version: v0.14.51 OS Version: Debian 10/Buster/testing (amd64), up-to-date as of today Browser Version: Firefox 62.0.3

canton7 commented 6 years ago

Unfortunately Debian's version has broken icon fonts :(

(See here and here and here for details -- the long and the short of it is that it should be fixed soon).

calmh commented 6 years ago

I agree that it's somewhat annoying that Debians "+hax" addition makes their version sort as higher. On the other hand that means there is at least a tie breaker... But the "-t ..." thing was new to me (as a >20 year Debian user...) and I think it's more annoying to suggest that by default in all cases... It's not a strongly held opinion though.

imsodin commented 6 years ago

The -t thingy is not enough, because a subsequent upgrade would then install the most recent version again. Really the only permanent solution (that I know) is setting the priority of the syncthing repo higher (using apt preferences config files). We could suggest to write the following into /etc/apt/preferences.d/syncthing:

Package: *syncthing*
Pin: origin apt.syncthing.net
Pin-Priority: 900

Package: *syncthing*
Pin: origin *
Pin-Priority: 100

However that's exposing lots of unsuspecting users to the can of worms that is apt_preferences...

An alternative is to make users aware, that there are packages in the main repo, and they should only use syncthing's repo if they want RCs or have another good reason (if you don't want RCs, the delay in releases is small enough nowadays that I wouldn't count being up-to-date as an important reason anymore).

calmh commented 6 years ago

I guess that depends on which Debian you’re following? Only sid or whatever does rolling upgrades I think? For other Debians and, like, Ubuntu our version will always be newer.

Currently the Debian shipped version is (cosmetically) broken, but otherwise they’re usually supposed to be equivalent and it doesn’t matter which one is used so long as it’s a modern version. So in the grand scheme of things, adding our repo should be safe and work as expected, if the expectation is to get a modern Syncthing that works. Sometimes we will be ahead, sometimes Debian will be, but the result is similar.

aviau commented 5 years ago

If I changed my versioning to use ~ instead of + then maybe we wouldn't have this problem at all.

I need to verify to be sure, but if I am right, then I really don't mind changing my versioning scheme.

calmh commented 5 years ago

Tilde would indeed be neat as they would then sort as lesser than the prefix-less package. (We do tilde for the RC:s etc, for this reason.)

aviau commented 5 years ago

It is too late for 0.14.54 as I already uploaded 0.14.54+ds1-1. However I will do it for 0.14.55.

calmh commented 5 years ago

Awesome

aviau commented 5 years ago

Done. I have uploaded syncthing 1.0.0~ds1-1 to Debian today.

Congrats on the 1.0 release by the way! :tada: