GODEBUG=tls13=1 is not a valid environment string

syncthing / syncthing-android

Wrapper of syncthing for Android.

https://syncthing.net/

Mozilla Public License 2.0

3.2k stars 367 forks source link

GODEBUG=tls13=1 is not a valid environment string #1384

Open olifre opened 4 years ago

olifre commented 4 years ago

Specifying the string: GODEBUG=tls13=1 as environment variable setting in the debugging settings (which works perfectly well e.g. on Linux) does not save in the app, but the message that this string is invalid is shown.

Version Information

App Version: 1.2.0
Syncthing Version: v1.2.0
Android Version: Android 9.0.8 (OxygenOS)

AudriusButkevicius commented 4 years ago

https://github.com/syncthing/syncthing-android/blob/4414dcc8a4412a377834e8a40f9df4fb446402a0//app/src/main/java/com/nutomic/syncthingandroid/service/SyncthingRunnable.java#L206-L209

The splitting logic does not support that

olifre commented 4 years ago

I think the splitting logic should only split each component (after the split at the space) at the very first equal sign, and not each one - this should fix the common case of GODEBUG.