search

syncthing / syncthing-android

Wrapper of syncthing for Android.
https://syncthing.net/
Mozilla Public License 2.0
3.38k stars 379 forks source link

Refactor groovy gradle files to kotlin dsl #2022

Closed adamszewe closed 9 months ago

adamszewe commented 10 months ago

Description:

Refactor gradle build files to use Kotlin DSL instead of Groovy. There were also a bash script and a python script that needed to be updated because they relied on parsing the build.gradle files written in Groovy.

This PR completes the work started in: https://github.com/syncthing/syncthing-android/pull/2000

imsodin commented 9 months ago

That was quite annoying to review with all the lines "changed", thus no usable diff, and needed to be checked that they actually didn't change semantically xD

One question about the signing store-file, otherwise lgtm.

adamszewe commented 9 months ago

That was quite annoying to review with all the lines "changed", thus no usable diff, and needed to be checked that they actually didn't change semantically xD

Sorry for any confusion and thanks for the in-depth review 😉 The python scripts were also a bit of a pain to update. They are a hacky solution and can be converted to dedicated gradle tasks in order to avoid relying on parsing gradle config files manually.

imsodin commented 9 months ago

Sorry for any confusion and thanks for the in-depth review 😉

Oh nothing to be sorry for, I didn't mean to complain about anything you have done. It was simply the very nature of the change that made it hard to review.