Fix F-Droid not displaying logo

[leoheitmannruiz]

Description

It seems F-Droid doesn't display Syncthing's logo at their website and in their client (at least on my end it is not shown).

According to the Wayback Machine, F-Droid did show the logo in the past, but it stopped being displayed between October and December of 2022:

https://web.archive.org/web/20221027141012if_/https://f-droid.org/en/packages/com.nutomic.syncthingandroid/ versus https://web.archive.org/web/20221208220952if_/https://f-droid.org/en/packages/com.nutomic.syncthingandroid/

This PR adds the Syncthing logo to the location expected by F-Droid, as per the Triple T structure which you seem to be using.

Changes

• Create 512x512 PNG from ic_launcher_full.svg using Inkscape (and compress using zopfli)
• Create icon directory according to the Triple T structure
• Copy PNG to appropriate location

[yurtpage]

generally speaking it looks like the F-Droid doesn't load the play listings at all. There are a lot of app description translations here https://github.com/syncthing/syncthing-android/tree/main/app/src/main/play/listings

But in the F-Droid nothing translated e.g. for the German it's still the English text https://f-droid.org/de/packages/com.nutomic.syncthingandroid/

From the F-Droid article https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

It looks like everything is correct.

Maybe we should ask on the F-Droid forum instead?

[leoheitmannruiz]

To me it seems that F-Droid does load the play listing. For example, it displays the Author email which is set in https://github.com/syncthing/syncthing-android/blob/main/app/src/main/play/contact-email.txt and not in the F-Droid build metadata at https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.nutomic.syncthingandroid.yml

Also, the release notes are displayed, which are part of the play listing: https://github.com/syncthing/syncthing-android/blob/main/app/src/main/play/release-notes/en-GB/default.txt

The reason the full description is not translated, I suspect, is that F-Droid has overwritten Syncthing's description in their build metadata. I assume they have done this as Syncthing's own descriptions contains links to the website, source code, issues... which F-Droid has a dedicated place for.

The short description is translated (see the link to the German page, you have provided), though these translations differe from Syncthing's, as they seem to come from their own translations https://hosted.weblate.org/projects/f-droid/fdroiddata/

I feel like this should be talked about with F-Droid. Perhaps I'll create a post in the forum or open an issue. If so, I'll comment here. Of course, you are free to do so as well :)

The icon situation, on the other hand, seems clear to me. The article you linked to defines where the icon should be placed and it currently isn't. I have placed it there.

Why do you think "everything is correct"?

Perhaps also see these: https://forum.f-droid.org/t/applications-icons-not-visible-in-f-droid/18955 https://forum.f-droid.org/t/missing-icon-on-apps/19831

[yurtpage]

Thank you for the detailed response. Please ask F-Droid devs. Just as guess, maybe the Tripple-T should be triggered to update descriptions but as far I understood the F-Droid can find the descriptions itself

[leoheitmannruiz]

Hey @imsodin :)

I assume you are going to bump syncthing-android to 1.27.7 soon. Could you please take a quick look at this PR before you do so? Perhaps F-Droid will then display the icon with the next release and the issue is no longer of relevance.

PS: I'm not sure if pinging is appropriate in this context.. I'm very sorry if it's not. I'd love some feedback in this regard.

[imsodin]

No worries about pinging, I follow everything in this repo anyway. However I am traveling until July with mobile only and won't be doing releases.

[leoheitmannruiz]

Ok :) Enjoy your travels!

[leoheitmannruiz]

Ups haha, I did look for it :-) Thanks!