search

syncweek-react-aad / react-aad

A React wrapper for Azure AD using the Microsoft Authentication Library (MSAL). The easiest way to integrate AzureAD with your React for authentication.
MIT License
344 stars 94 forks source link

Migrate sample to Typescript w/ Hooks #171

Closed AndrewCraswell closed 4 years ago

AndrewCraswell commented 4 years ago

Is your feature request related to a problem? Please describe. The sample app is an easy way to manually test changes before deploying changes. However, since the sample is not in TypeScript, the manual tests are not managing to capture static typing issues. This has caused a few releases where the proper interfaces are not being exposed properly.

Describe the solution you'd like This is a completely avoidable situation if the sample being used for manual testing is also in TypeScript so we can use the proper types. It would also generally provide better examples of proper usage for TyepScript users.

Describe alternatives you've considered It could also be possible to add an additional sample project for TypeScript, and leave the older JavaScript version alone. Having two samples would be better, but I' afraid this might decrease development velocity since updates will need to be made to multiple samples, and a new monorepo structure would need to be adopted.

These are all things we probably should do at some point, but perhaps when the library has reached a better point of maturity.

BlackFenix2 commented 4 years ago

Sounds like something i can handle. i can attempt to port this project to typescript and add hooks.

also, props for using yarn workspaces! i can organize the tooling away!

AndrewCraswell commented 4 years ago

@BlackFenix2 Organizing the tooling would be a huge improvement too! I've been tripping all over it 😂

BlackFenix2 commented 4 years ago

@AndrewCraswell i got a PR ready, the SampleAppRedirectOnLaunch was a bit of a challenge to refactor with hooks.

I can still help with separating tooling but i didn't want to do too much on one PR.