search

syncweek-react-aad / react-aad

A React wrapper for Azure AD using the Microsoft Authentication Library (MSAL). The easiest way to integrate AzureAD with your React for authentication.
MIT License
344 stars 94 forks source link

Unable to use tinymce-react and my component call componentWillUnmount when I go to page first time. #185

Closed anupong-s closed 4 years ago

anupong-s commented 4 years ago

Describe the bug I unable to use tinymce-react in my project when I wrap <AzureAD> with my route (Please see below picture). I observe that my containers and components called componentWillUnmount event though I access that page first time. If I misunderstand, componentWillUnmount will be called that when I leave that page or route to other page.

image

Another one I found when I get asynchronous data from api in componentDidMount and then I store the data in state. I found warning in console (below picture).

image

I am not sure this is a bug of <AzureAD> or not but If I am not use <AzureAD>, I am not found this issue.

Library: react-aad-msal: 2.2.4 msal: 1.2.0 @tinymce/tinymce-react: 3.3.1

AndrewCraswell commented 4 years ago

These look like generic React issues. Since this is an old issue, I'm going to close. But if you have a minimalist repo that can demonstrate the issue I will reopen and take a look at what is going on.