search

syncweek-react-aad / react-aad

A React wrapper for Azure AD using the Microsoft Authentication Library (MSAL). The easiest way to integrate AzureAD with your React for authentication.
MIT License
344 stars 94 forks source link

reference issue in typings/interfaces/IAuthProvider.d.ts #192

Closed YoannDe closed 4 years ago

YoannDe commented 4 years ago

Library versions

Describe the bug Cannot find 'src/enums' in typings/interfaces/IAuthProvider.d.ts

Expected behavior It should be able to find the path, the src folder doesn't exists in the dist folder. The path is invalid.

To Reproduce Steps to reproduce the behavior:

  1. Run npm i react-aad-msal
  2. In Vs code , there is the following error message

Desktop (please complete the following information):

AndrewCraswell commented 4 years ago

Thanks! I'll see if I can get a fix for this pushed out ASAP after office hours.

tomalex0 commented 4 years ago

@AndrewCraswell is this change good enough to fix the issue ? https://github.com/syncweek-react-aad/react-aad/compare/master...tomalex0:patch-1?expand=1

AndrewCraswell commented 4 years ago

@tomalex0 Really close, I think there might be a couple other imports in other files that import from "src/" path. If you double check those I will accept a PR and release tonight :)

nhance commented 4 years ago

Can we merge and release this?

tomalex0 commented 4 years ago

Created a PR https://github.com/syncweek-react-aad/react-aad/pull/194 @AndrewCraswell Was able to make sample app running from my local based on two reference changes.

AndrewCraswell commented 4 years ago

Merged and released in version 2.3.2.

OscarGalindo commented 4 years ago

Still the same error with another import:

dist/typings/AuthenticationActionCreators.d.ts: import { IAccountInfo } from 'src/interfaces';

OscarGalindo commented 4 years ago

Here you have more information: https://github.com/Microsoft/TypeScript/issues/15479

It's something that can't be fixed at build time for now, we should avoid using paths based on baseUrl from tsconfig, what do you think?