fix import using baseUrl - Githubissues

syncweek-react-aad / react-aad

A React wrapper for Azure AD using the Microsoft Authentication Library (MSAL). The easiest way to integrate AzureAD with your React for authentication.

MIT License

344 stars 94 forks source link

fix import using baseUrl #205

Closed OscarGalindo closed 4 years ago

OscarGalindo commented 4 years ago

Purpose

Remove import based on baseUrl and use relative path instead

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Compile and see typings are working.

Other Information

We should avoid using baseUrl as base path to imports

AndrewCraswell commented 4 years ago

Thank you for this! I'm traveling at the moment and don't have access to WiFi, but will get this released as soon as I do.

umusicanumothu commented 4 years ago

How we can use this fix?

npm install --save https://github.com/syncweek-react-aad/react-aad.git#release-636 throwing error.

Can't install git+https://github.com/syncweek-react-aad/react-aad.git#091cded5a06cc34c35ddf903fd38733d6bc4dbd4: Missing package name