search

syndenbock / MinimapButtonButton

A World of Warcraft addon for collecting minimap buttons
7 stars 4 forks source link

Auto close #13

Open OnceWasPerfect opened 2 years ago

OnceWasPerfect commented 2 years ago

Awesome addon, an enhancement idea would be to have the menu either auto close after selecting something inside it (probably difficult with addons that create their own menus like itemrack) or in lieu of that close after a certain number of seconds. Often times I'll open it to get to Plater options or something and then it stays open covering my minimap until I go down and click it again.

SCUR0 commented 2 years ago

This would also help when you get in combat and can't close the menu due to API restrictions while in combat.

jtmunn commented 2 years ago

I, too, would love this feature. @syndenbock I could create a PR if you are interested in letting others contribute?

syndenbock commented 2 years ago

As @OnceWasPerfect already said, the handling of submenus will propably cause issues when they open a menu that is attached to the given button, which is why I didn't attempt to implement this yet. @jtmunn Feel free to fork this repo and create a PR if you want to contribute.

SCUR0 commented 2 years ago

the handling of submenus will propably cause issues when they open a menu that is attached to the given button, which is why I didn't attempt to implement this yet.

This is already an issue with the default behavior. I have to make sure to close the sub menus before I close MMBB

jbelvin85 commented 2 years ago

I noticed that the icons fade after I move my mouse off of the minimap. would there be a way to latch on to when this happens and use that to close or hide the container?

syndenbock commented 2 years ago

I noticed that the icons fade after I move my mouse off of the minimap. would there be a way to latch on to when this happens and use that to close or hide the container?

Auto-closing when the container loses focus should be possible. The issue here is to not close the container while a submenu of a button is being displayed so the submenu does not disappear aswell.