syndesisio / connectors

Apache Camel Connectors for Syndesis
Apache License 2.0
6 stars 12 forks source link

JSon schem using boolean and numeric types for their values #2

Closed davsclaus closed 7 years ago

davsclaus commented 7 years ago

Hi @gashcrumb

Wonder if you see a problem if we change the JSon schema to use boolean and numeric values for some of the fields.

You can see a JIRA and example here https://issues.apache.org/jira/browse/CAMEL-10842

I think I can adjust the internal json emitter and parser in Apache Camel to support this and we can make the generated JSon schema a bit nicer.

jimmidyson commented 7 years ago

Yes please!

gashcrumb commented 7 years ago

Yeah, absolutely we can support that. Also 'password' would be good for protected fields.

On Feb 16, 2017 4:50 AM, "Jimmi Dyson" notifications@github.com wrote:

Yes please!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redhat-ipaas/connectors/issues/2#issuecomment-280284200, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVdrIgvJl73kQGZ1LD7kq-DNoc5GKwDks5rdBvVgaJpZM4MCuyN .

davsclaus commented 7 years ago

We can debate whether password is only for password fields, but what about secret api tokens and the likes?

And some may wat to hide usernames as well, and therefore the json schema today has secret: true|false to indicate whether fields are considered sensitive.

gashcrumb commented 7 years ago

Ah, excellent, that works too...

On Feb 16, 2017 6:41 AM, "Claus Ibsen" notifications@github.com wrote:

We can debate whether password is only for password fields, but what about secret api tokens and the likes?

And some may wat to hide usernames as well, and therefore the json schema today has secret: true|false to indicate whether fields are considered sensitive.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redhat-ipaas/connectors/issues/2#issuecomment-280308533, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVdrA_VR8RzDcGiKzROx3eKfPvfEvIEks5rdDXjgaJpZM4MCuyN .

davsclaus commented 7 years ago

So almost got the bits working now. The connector maven plugin needed some extra tweaks as well. When I got the bits correct at Apache then I will do the needed changes on the connectors JSon schema files here as well.