syndesisio / fuse-online-install

Installation templates and other objects for installing Red Hat Fuse Online (based on Syndesis)
Apache License 2.0
13 stars 37 forks source link

Extract CLI binaries at release time and put them to `jboss-fuse/fuse-operators` for download #107

Closed heiko-braun closed 2 years ago

heiko-braun commented 5 years ago

Remove the need to have docker available to install camel k and syndesis

valdar commented 5 years ago

The easiest way to do that is by releasing kamel binaries as separate artefacts instead of putting them in the came-k operator image.

asmigala commented 5 years ago

Same thing with syndesis for 7.5

heiko-braun commented 5 years ago

We will ship them with the operator image, but extract the binary during the release of fuse-online-install. This way docker doesn't become a prerequisite for end users, but it will still be needed at release time.

asmigala commented 5 years ago

@heiko-braun and the binary will be then commited to this repo? The problem with that is that the operator image only has the linux binary, so it won't be possible to install from windows or mac

nicolaferraro commented 5 years ago

For camel k, the operator image has clients for all platforms under /opt/clients, I guess it's possible to do the same for Syndesis.

But.. is this really the way we want to go? The approach of putting the client binary inside the operator image is one of the main reasons why we are not able to embed the right operator image tag in the binary tool. We had to do hacks in this repo during previous Fuse releases.

Why putting such constraint if we later extract the clients from the images? @lgarciaaco , @heiko-braun

heiko-braun commented 5 years ago

For camel k, the operator image has clients for all platforms under /opt/clients, I guess it's possible to do the same for Syndesis.

Yes, that's what we need.

heiko-braun commented 5 years ago

Why putting such constraint if we later extract the clients from the images?

We are taking a shortcut in 7.5. It seemed to be easier to do this way for now, rather than asking the prod processes to change.

@nicolaferraro Can you elaborate on the problem you see with the the right operator image tag in the binary tool?

nicolaferraro commented 5 years ago

No problem for me, if images come with binaries inside it's easy to extract them and put them somewhere where the scripts can download them.

The problem I was mentioning is a productization issue somebody mentioned in the past.

Basically if I want kamel install to install the productized version of Camel K, then the kamel binary needs to know the exact image tag to install e.g. redhat-fuse/camel-k:1.8-14. Sinc kamel is inside the image, it needs to know in advance the tag that will be produced, before building the image. But as I've understood, the tag is only known when the image is later published.

And this means that we need to do hacks in this repo to fix it, which is not a problem given that we don't distribute binary directly.

I changed my mind on the previous comment because in syndesis and camel k (master, not prod), we now have a single binary and we can't avoid putting it in the image..

lgarciaaco commented 5 years ago

@heiko-braun jboss/fuse-operators repo is not public ... how are ppl supposed to download the binaries from there

phantomjinx commented 2 years ago

Issue has been marked as stale and closed. If it is really required then please reopen and request with justification accordingly.