search

syndesisio / syndesis-openshift-templates

OpenShift Templates for Syndesis
7 stars 18 forks source link

fix: Fix dodgy oauth proxy image names #126

Closed jimmidyson closed 7 years ago

jimmidyson commented 7 years ago

Fixes #124

jimmidyson commented 7 years ago

Tests are failing because test cluster (rh-idev) doesn't support re-encrypted routes using service serving certificates due to the version of OpenShift deployed (3.5 in staging vs 3.6 in prod):

error: Route "syndesis-rest" is invalid: spec.tls.destinationCACertificate: Required value

This is an enhancement that I could drop back to edge termination but really do like the effectively end-to-end encryption that re-encrypted routes provide. I hate to drop back to work around previous versions of openshift when our target prod platform gives us the capabilities we want.

Thoughts @rhuss @zregvart @dsimansk?

pure-bot[bot] commented 7 years ago

Pull request approved by @rhuss - applying approved label

rhuss commented 7 years ago

@jimmidyson I agree that making compromises only because of our weird dev setup is not nice. I would however still go for a common solution, since I think it's still secure (although not that secure). We should raise an issue as reminder, that when we resolved the situation with 3.5 dev vs. 3.6 prod we go back to the renecrypt strategy.

rhuss commented 7 years ago

BTW, i would be cool if we collect somewhere all the issues we had with the discrepancy of prod vs dev cluster (just to have some datapoints for arguments)

So far I remember:

dsimansk commented 7 years ago
jimmidyson commented 7 years ago

Switched back to edge encryption.

Jenkins is dead so no PR testing...