search

syndesisio / syndesis-project

Placeholder repository for project management
https://syndesis.io/
Apache License 2.0
6 stars 12 forks source link

How to update credentials of a connection of an existing integration? #10

Closed chirino closed 6 years ago

chirino commented 7 years ago

How do you update credentials of a connection of an existing integration? Updating the connection seems to not be enough to get the integration to pickup the credential updates.

rhuss commented 7 years ago

When an integration is out in the wild it's get not updated anymore as the deployment files for the integration has already been created. This is true for any configuration.

The question how such an update should happen:

  1. Should the integration be stopped, the deployment files updated and then a new integration pod started ? (when the integration is updated).
  2. Should the integration be able to update its configuration live? (e.g. via watching a file in a mounted volume which is updated from syndesis-rest ?)

Actually, I think option 1 is not so a bad one, as it would also apply if you change something structurally in the integration. Something like a 'Redeploy' button would be ok here.

For the connection, things are a bit different as a connection can be used in many integrations. Actually, when updating a connection, every integration referencing these connections needs to be re-deployed (another +1 for a relational model to find out those integrations).

But at the end, when updating a connection, a warning should pop up, listing all affected integrations and a "Do you want to redeploy these intergations" ?

chirino commented 7 years ago

Note that if we don't force the runtime system to match what is viewable as the current state of the system is presented by the UI, then we need the UI to also notify users that their integration is using older versions of configurations. Right now there is no way to tell that unless your peek into the back end systems and compare what is configured in the ipaas uis and what is actually deployed.

rhuss commented 7 years ago

Completely agreed. Forcing the runtime to always match would require are redeployment on each change in the integration via the UI. I don't think this is desirable.

So maybe we should introduce some sort of versioning for integrations (keeping old integrations in the DB, too) ? Somewhat like for k8s Deployments ? In the UI we would need to allow to look at older versions of integrations, with the active integration marked. With this in place, we would be able to allow a rollback, too. Naively I would directly mimic the state and versioning of Deployments, which solves a similar use case for Kubernetes.

@chirino @kcbabo Should we add a user story for this?

zregvart commented 7 years ago

How do you update credentials of a connection of an existing integration? Updating the connection seems to not be enough to get the integration to pickup the credential updates.

For the OAuth POC I used spring-cloud-kubernetes and k8s secrets. When the secret is updated the Spring application context is reloaded. This would in turn stop and start Camel context and the component would be using the new credentials after that. We could consider adding support for reloading Camel routes on property change. A bit of this is present for XML routes, and perhaps can be extended to support funktion.

chirino commented 6 years ago

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

chirino@gmail.com Domain hiramchirino.com has exceeded the max emails per hour (172/150 (114%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from o7.sgmail.github.com ([167.89.101.198]:36615) by host313.hostmonster.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from bounces+848413-18a6-hiram=hiramchirino.com@sgmail.github.com) id 1f0Nmk-0013cx-GQ for hiram@hiramchirino.com; Mon, 26 Mar 2018 02:47:22 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=13E4YPvmTsz0QKqYazr4dErllFs=; b=UKX++1b177M0GQvp dAXZe2MUkEhcdGQI/8dqXXV0i2t6bt/FJ8pL4rHISTiW5PKOh4OQBqKnjZ7kQRFy IO12pIVlm35f+Mwj+sst8KySlTWjU20L6U8izQGRO/FCe8u0RogslR/oSAo80V42 Cu95PQ3/rD40J4JOgU4XncUuxng= Received: by filter0558p1mdw1.sendgrid.net with SMTP id filter0558p1mdw1-29596-5AB8B38F-8 2018-03-26 08:47:11.21142507 +0000 UTC Received: from smtp.github.com (out-3.smtp.github.com [192.30.252.194]) by ismtpd0022p1iad2.sendgrid.net (SG) with ESMTP id Rrkk2catQdyMpxhvBEMc6g for hiram@hiramchirino.com; Mon, 26 Mar 2018 08:47:11.029 +0000 (UTC) Date: Mon, 26 Mar 2018 08:47:11 +0000 (UTC) From: Zoran Regvart notifications@github.com Reply-To: syndesisio/syndesis-project reply@reply.github.com To: syndesisio/syndesis-project syndesis-project@noreply.github.com Cc: Hiram Chirino hiram@hiramchirino.com, Mention mention@noreply.github.com Message-ID: syndesisio/syndesis-project/issue/10/issue_event/1540317470@github.com In-Reply-To: syndesisio/syndesis-project/issues/10@github.com References: syndesisio/syndesis-project/issues/10@github.com Subject: Re: [syndesisio/syndesis-project] How to update credentials of a connection of an existing integration? (#10) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5ab8b38f1e4c2_371e3f87be6a8f30400169"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: zregvart X-GitHub-Recipient: chirino X-GitHub-Reason: mention List-ID: syndesisio/syndesis-project List-Archive: https://github.com/syndesisio/syndesis-project List-Post: mailto:reply@reply.github.com List-Unsubscribe: mailto:unsub+000193578818acbfb64036145d3d63aaad42d83575842d4892cf0000000116d0758f92a169ce0dffc330@reply.github.com, https://github.com/notifications/unsubscribe/AAGTVxdSR55ptzaIT1e6ANGPEIaSgmUaks5tiKsPgaJpZM4N1hIt X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: hiram@hiramchirino.com X-SG-EID: r3yY3NeKU5c391Z9JqIJsAQ+rIWE1mJvBRhY4sfmQMsiRJslKHFoQa7k31FVb+iPTg0egmUZB3eFGm fCzbp+/+2GC8sW1GvB9tKdu7ZaUBeB9QaOLssxLoJhQk+LZIWqycMg6vnIoyzhLOeeXrAQICKQzYrL RcWX4wOHy9YZyFJERq5lljQw9/HM0IY5Oz4DZIoNMdCdfzihZ6UkwGQjCbQ0u4Bkwnajiui4iXRqfE g=

----==_mimepart_5ab8b38f1e4c2_371e3f87be6a8f30400169 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit

Closed #10.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/syndesisio/syndesis-project/issues/10#event-1540317470 ----==_mimepart_5ab8b38f1e4c2_371e3f87be6a8f30400169 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Closed #10.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5ab8b38f1e4c2_371e3f87be6a8f30400169--