search

syndesisio / syndesis-project

Placeholder repository for project management
https://syndesis.io/
Apache License 2.0
6 stars 12 forks source link

Empty validation message when creating a new Connection with invalid values #111

Closed apupier closed 6 years ago

apupier commented 7 years ago

image

gashcrumb commented 7 years ago

@zregvart @rhuss looks like the response back from the verifier doesn't contain a description any more, any ideas?

Here's what I'm seeing:

[
  {
    "status": "ERROR",
    "scope": "PARAMETERS",
    "errors": [
      {
        "code": "ILLEGAL_PARAMETER_GROUP_COMBINATION",
        "parameters": [
          "clientSecret",
          "userName",
          "refreshToken"
        ],
        "attributes": {
          "GROUP_NAME": "USERNAME_PASSWORD",
          "GROUP_OPTIONS": "clientId,clientSecret,keystore,password,refreshToken,userName"
        }
      },
      {
        "code": "ILLEGAL_PARAMETER_GROUP_COMBINATION",
        "parameters": [
          "password",
          "clientSecret"
        ],
        "attributes": {
          "GROUP_NAME": "REFRESH_TOKEN",
          "GROUP_OPTIONS": "clientId,clientSecret,keystore,password,refreshToken"
        }
      },
      {
        "code": "ILLEGAL_PARAMETER_GROUP_COMBINATION",
        "parameters": [
          "password",
          "keystore",
          "userName",
          "refreshToken"
        ],
        "attributes": {
          "GROUP_NAME": "JWT",
          "GROUP_OPTIONS": "clientId,keystore,password,refreshToken,userName"
        }
      }
    ]
  }
]

On this particular page the UI is building that error box using description attributes from the response.

zregvart commented 7 years ago

I don't think we ever had description defined for ILLEGAL_PARAMETER_GROUP_COMBINATION type errors. Looking at the code that could add the description it never does/did that (ResultErrorHelper.java#L105-L149).

@lburgazzoli does it make sense for the ResultErrorHelper to generate description in that case or should we handle it in the verifier?

rhuss commented 7 years ago

@apupier btw, how did you end up at this screen ? Thought we all about OAuth these days, so never have seen this form with adding tokens since smiem ttime. Which connector are you using ?

rhuss commented 7 years ago

btw, I would also croak about the encoding issue with your name in top right of the screen ;-) wonder how we can fix that ?

zregvart commented 7 years ago

Which connector are you using ?

this happens when you create connection for a credential (OAuth) based connector that hasn't been setup (no clientId/Secret)

apupier commented 7 years ago

btw, I would also croak about the encoding issue with your name in top right of the screen ;-) wonder how we can fix that ?

I reported another issue for that https://github.com/syndesisio/syndesis-project/issues/110

chirino commented 6 years ago

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

chirino@gmail.com Domain hiramchirino.com has exceeded the max emails per hour (165/150 (110%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from o1.sgmail.github.com ([192.254.114.176]:27379) by host313.hostmonster.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from bounces+848413-18a6-hiram=hiramchirino.com@sgmail.github.com) id 1f0Nmg-0013ZL-LA for hiram@hiramchirino.com; Mon, 26 Mar 2018 02:47:18 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=kRgJ8YHvo5Zl8RgDD+p9997bSCQ=; b=QEwhboE6qiLlTajg bprYst3OJieZUTMcMxOlwPphM1NdfK5gzJaziMs6wYRUjEs/6Q7ZDboav8Emt1cZ Q35R3HL9HP9v/qzNBueiTYlOFmhDlVhtDFkBDh7/AOvQY92Ekw2ZzEUPCfOuy8Gx tNllSKpslsjJ0YW0by/5bNrHmgg= Received: by filter0469p1iad2.sendgrid.net with SMTP id filter0469p1iad2-6887-5AB8B388-1F 2018-03-26 08:47:04.723350599 +0000 UTC Received: from smtp.github.com (out-2.smtp.github.com [192.30.252.193]) by ismtpd0007p1iad2.sendgrid.net (SG) with ESMTP id 6174ejg7QQK4BMSsplRuxQ for hiram@hiramchirino.com; Mon, 26 Mar 2018 08:47:04.632 +0000 (UTC) Date: Mon, 26 Mar 2018 08:47:04 +0000 (UTC) From: Zoran Regvart notifications@github.com Reply-To: syndesisio/syndesis-project reply@reply.github.com To: syndesisio/syndesis-project syndesis-project@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Message-ID: syndesisio/syndesis-project/issue/111/issue_event/1540317055@github.com In-Reply-To: syndesisio/syndesis-project/issues/111@github.com References: syndesisio/syndesis-project/issues/111@github.com Subject: Re: [syndesisio/syndesis-project] Empty validation message when creating a new Connection with invalid values (#111) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5ab8b3889aa52_48203fdaac4c2f2c152279"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: zregvart X-GitHub-Recipient: chirino X-GitHub-Reason: subscribed List-ID: syndesisio/syndesis-project List-Archive: https://github.com/syndesisio/syndesis-project List-Post: mailto:reply@reply.github.com List-Unsubscribe: mailto:unsub+0001935710d2ef8976a3b2f54c6e08846cafe9f8611402e092cf0000000116d0758892a169ce0fa4afa1@reply.github.com, https://github.com/notifications/unsubscribe/AAGTV7X4B0yCpxQbrqq336EzGJbGcRhaks5tiKsIgaJpZM4PsNk3 X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: hiram@hiramchirino.com X-SG-EID: r3yY3NeKU5c391Z9JqIJsAQ+rIWE1mJvBRhY4sfmQMswHV19UP0TU6+WBLjJ9bXYplz3qikWSHU3SM /gaK6TfoXroEkhUyUnU/CvPAckie75CfiJXrp31YNJ7gZHp78LR0qLzvQ8Z0aDqhmsqK84CwQIIT4N E5rC0DJ51mE2gzBGLsjTvkb3kEAHvzjpwcQe9xzLfIesSnCfjGSYfifZsSf9q51E4tDqxNqgKLDcS4 w=

----==_mimepart_5ab8b3889aa52_48203fdaac4c2f2c152279 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit

Closed #111.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/syndesisio/syndesis-project/issues/111#event-1540317055 ----==_mimepart_5ab8b3889aa52_48203fdaac4c2f2c152279 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Closed #111.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5ab8b3889aa52_48203fdaac4c2f2c152279--