search

syndesisio / syndesis-react

[FORK] A flexible, customizable, open source platform that provides core integration capabilities as a service.
Apache License 2.0
3 stars 19 forks source link

fix: Add syntax examples in condition help block #436

Closed christophd closed 5 years ago

christophd commented 5 years ago

Fixes #5485

riccardo-forina commented 5 years ago

PR Storybook available here

gashcrumb commented 5 years ago

Thanks for the PR! I wonder though, the text looks a bit repetitive in practice:

image

Could add a <p> here (well, right before that line) with the syntax examples. I wonder then if we'd even need the field level help block.

gashcrumb commented 5 years ago

@dongniwang thoughts on that actually? Or would we rather have the field-level help like that?

christophd commented 5 years ago

@gashcrumb I tried this with a wider screen so that the help blocks were not using a line breaks. In your screenshot the repeating help blocks do look a bit overloaded, agreed

gashcrumb commented 5 years ago

Yeah, you're right that does look better. Lately I've been thinking I might need a monitor upgrade :-)

pure-bot[bot] commented 5 years ago

Pull request approved by @gashcrumb - applying approved label

dongniwang commented 5 years ago

Awesome! Thanks for the PR! It's a great step forward now that we provide more help to our users.

In the screenshot - What are the texts inside the input fields? Are they prefill by default? Feel like the screen is a little busy with all the texts and users might lose focus on what's the primary task here on the screen.

dongniwang commented 5 years ago

Ran into this strange behavior when looking at the PR.

Seems like we replace the helper text below the input field with validation text in a pretty subtle way. And I can't seem to be able to get the helper text to show up again. See screenshot below.

cc: @seanforyou23 here for his input as well.

conditionalFlow-helptext