fix: template step requires an output data shape to be selected

syndesisio / syndesis-react

[FORK] A flexible, customizable, open source platform that provides core integration capabilities as a service.

Apache License 2.0

3 stars 19 forks source link

fix: template step requires an output data shape to be selected #443

Closed riccardo-forina closed 5 years ago

riccardo-forina commented 5 years ago

Bug reported here.

(oh also fixes a bug with the integration list item that was causing a lot of console errors to be logged)

riccardo-forina commented 5 years ago

Fixes https://github.com/syndesisio/syndesis/issues/5652

riccardo-forina commented 5 years ago

PR Storybook available here

gashcrumb commented 5 years ago

So, we've actually relaxed some restrictions beyond the angular app now in the react app. I think we decided that the template step can just be available whenever, right @christophd ?

phantomjinx commented 5 years ago

So, we've actually relaxed some restrictions beyond the angular app now in the react app. I think we decided that the template step can just be available whenever, right @christophd ?

Given the template-step requires an input datashape as the datasource of its symbol substitution, I can't understand how that could be the case, eg.

Timer -> Template -> Log
Template's template: The Quick ${brown} fox jumped over the lazy dog
Where does the data come from that ${brown} gets substituted for?

gashcrumb commented 5 years ago

Ah, I see, ok great, thanks!

pure-bot[bot] commented 5 years ago

Pull request approved by @gashcrumb - applying approved label