search

syndesisio / syndesis-react

[FORK] A flexible, customizable, open source platform that provides core integration capabilities as a service.
Apache License 2.0
3 stars 19 forks source link

defer registering the service worker until the app loads it's config #452

Closed gashcrumb closed 5 years ago

riccardo-forina commented 5 years ago

PR Storybook available here

riccardo-forina commented 5 years ago

Now that I think about that, the config.json isn't under auth on CI, so we can't really check this out without merging (or testing on minishift I guess?)

gashcrumb commented 5 years ago

Yeah, I think so, no biggie I will give it a test later on today. My Chrome instance is in just the right state with a stale auth token also and this obviously hasn't changed things :smile:

gashcrumb commented 5 years ago

What I might do then is wait until the call to https://syndesis-staging-2.b6ff.rh-idev.openshiftapps.com/api/v1/users/~ succeeds since we always make that anyways and see if that does the trick.

gashcrumb commented 5 years ago

Made that change, will see if that helps things.

riccardo-forina commented 5 years ago

PR Storybook available here

pure-bot[bot] commented 5 years ago

Pull request approved by @riccardo-forina - applying approved label