search

syndesisio / syndesis-react

[FORK] A flexible, customizable, open source platform that provides core integration capabilities as a service.
Apache License 2.0
3 stars 19 forks source link

fix: undo really trivial styling issue that happened, nothing to see here honest #472

Closed gashcrumb closed 5 years ago

gashcrumb commented 5 years ago

has nothing to do with https://github.com/syndesisio/syndesis/issues/5732

@seanforyou23 shhh

pure-bot[bot] commented 5 years ago

Pull request approved by @seanforyou23 - applying approved label

pure-bot[bot] commented 5 years ago

Pull request approved by @seanforyou23 - applying approved label

riccardo-forina commented 5 years ago

Wha? I don’t wanna know

seanforyou23 commented 5 years ago

@riccardo-forina it looks like if we import anything from @syndesis/ui before we import the main App import { App, ... } from './app'; then the order of injected css styles is wrong in the resulting DOM. App needs to load first before other component stylesheets since it is what's importing the base styles (which contain resets).

Could probably refactor how these imports are structured but for now this get's us back to the stable point we've been seeing all week. I know you said you didn't wanna know, but I wanted you to know :)

riccardo-forina commented 5 years ago

Now I want to unknown it all.

riccardo-forina commented 5 years ago

PR Storybook available here