syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

Project generator could create a bit nicer unique component aliases #630

Closed zregvart closed 7 years ago

zregvart commented 7 years ago

Our component aliases currently contain connectionId, which is not too user friendly (for example twitter-mention-connector--KuYUr3kEMhDH0Nq8VGV). We could generate aliases by following two simple rules

This should lead to component aliases that look something like this in the generated syndesis.yml:


---
flows:
- steps:
  - kind: endpoint
    uri: twitter-mention-connector:MENTIONS
  - kind: endpoint
    uri: atlas:mapping-step-2.json
  - kind: endpoint
uri: salesforce-upsert-sobject-1?sObjectIdName=TwitterScreenName__c&sObjectName=Contact
  - kind: endpoint
uri: salesforce-upsert-sobject-2?sObjectIdName=TwitterScreenName__c&sObjectName=Opportunity
lburgazzoli commented 7 years ago

This would generate a little bit of inconsistency in secrets as it would result in something like:

twitter-mention-connector.clientId = ...
twitter-mention-connector.clisnetSecret = ...

salesforce-upsert-sobject.configurations.salesforce-upsert-sobject-1.userName = ...
salesforce-upsert-sobject.configurations.salesforce-upsert-sobject-1.password = ...

salesforce-upsert-sobject.configurations.salesforce-upsert-sobject-2.userName = ...
salesforce-upsert-sobject.configurations.salesforce-upsert-sobject-2.password = ...

So there is something that uses the configurations syntax and something not, is that ok ?

zregvart commented 7 years ago

Any thoughts on the comment above @iocanel @jimmidyson @rhuss @KurtStam?

zregvart commented 7 years ago

@lburgazzoli I think that would be ok, as most integrations I think would use only single connection.

lburgazzoli commented 7 years ago

If Zoran's solution looks ok I can work on this tomorrow (so it can solve #660)