search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

Swagger.json link only shows one operation #646

Closed gashcrumb closed 6 years ago

gashcrumb commented 7 years ago

Noticed that the swagger link that points to swaggerui in the readme only shows the /setup path and no other operations but instead a little error box as it fails to validate:

{
  "messages": [
    "attribute info.title is missing"
  ],
  "schemaValidationMessages": [
    {
      "level": "error",
      "domain": "validation",
      "keyword": "required",
      "message": "object has missing required properties ([\"title\"])",
      "schema": {
        "loadingURI": "http://swagger.io/v2/schema.json#",
        "pointer": "/definitions/info"
      },
      "instance": {
        "pointer": "/info"
      }
    }
  ]
}

It'd be good if the whole swagger rendered properly -> https://online.swagger.io/validator/debug?url=https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/swagger.json

zregvart commented 7 years ago

I wonder why is this still the case now that we've removed GitHub setup from the backend?

KurtStam commented 7 years ago

The title field was added in https://github.com/syndesisio/syndesis-rest/pull/731/commits/fb836a79353c3efbe6acaaf229dd8161d16a13f9, but a new issue popped up

Swagger schema validation failed. Array items are not unique (indexes 0 and 1) at #/paths//connectors/{id}/actions/{id}/get/parameters

where we simply have to better name the id field parameters. first id -> connectionId second id -> actionId

KurtStam commented 7 years ago

@jimmidyson I tried overriding the second parameter with 'actionId' but that doesn't seem to be possible. I think we only have two options:

Any thoughts?