search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

refactor(git): Replace Git #668

Closed rhuss closed 7 years ago

rhuss commented 7 years ago

This is the start of removing calling out to GitHub for storing integrations. Instead the generated runtime files are directly send as binary input to a s2i source build. These files exist only temporarily on disc.

The first step was to remove git and switch to calling a binary build. It is currently not yet end2end tested.

The next steps are also to get rid of all Keycloak references and adapt the deployment accordingly.

Still need to understand how the OpenShift oauthclient can be used for substituting authentication (can it ?)

The 'github' module has been removed.

jimmibot commented 7 years ago

@rhuss, thanks! @KurtStam, please review this.

jimmidyson commented 7 years ago

would be good to merge this then work on removing keycloak in subsequent pr

jimmidyson commented 7 years ago

I'll review later today

retest this please

jimmidyson commented 7 years ago

Conflict to resolve!

jimmidyson commented 7 years ago

Merged master, fixed conflicts. Fingers crossed.

rhuss commented 7 years ago

@jimmidyson thanks !

Btw, I guess its now better to merge from master than to rebase on master as the changes are that big that rebasing doesn't work well anyway.

jimmidyson commented 7 years ago

Well my main reason to merge is when pushing to someone else's PR branch, if you force push then it closes the PR :scream:

rhuss commented 7 years ago

@zregvart @KurtStam @jimmidyson all green now. I know, review might be a bit tedious, but we need to get this merged asap. Its needed for TP1 ;-)

pure-bot[bot] commented 7 years ago

Pull request approved by @jimmidyson - applying approved label

pure-bot[bot] commented 7 years ago

Pull request approved by @jimmidyson - applying approved label