fix: Proper build and deployment handling

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.

https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/

Apache License 2.0

6 stars 17 forks source link

fix: Proper build and deployment handling #678

Closed rhuss closed 7 years ago

rhuss commented 7 years ago

For now we are triggering a deployment explicitly, to circumvent issue on our target platform which has problems with deployment triggers.

However I was not able to disable image triggers on the deployment, otherwise imagestream could not be used. This cause a double deployment on platforms with working triggers This is not nice but should not harm to much.

jimmibot commented 7 years ago

@rhuss, thanks! @KurtStam, please review this.

zregvart commented 7 years ago

Checkstyle complains with:

[INFO] There is 1 error reported by Checkstyle 6.19 with checkstyle.xml ruleset.

[ERROR] src/main/java/io/syndesis/controllers/integration/StatusChangeHandlerProvider.java:[35,19] (modifier) ModifierOrder: 'private' modifier out of order with the JLS suggestions.

pure-bot[bot] commented 7 years ago

Pull request approved by @zregvart - applying approved label