search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

fix: Allow snapshot deployments to the oss.sonatype.org mvn repos. #690

Closed chirino closed 7 years ago

jimmibot commented 7 years ago

@chirino, thanks! @KurtStam, please review this.

KurtStam commented 7 years ago

@chirino why do we want SNAPSHOTS?

jimmidyson commented 7 years ago

I can't see any reason for this.

chirino commented 7 years ago

I don't see any reason to not support it.

chirino commented 7 years ago

At least with a snapshot, I can test out the script at: https://github.com/syndesisio/syndesis-s2i-image/blob/master/run.sh#L28

until a version gets released.

chirino commented 7 years ago

retest this please

jimmidyson commented 7 years ago

But we don't publish snapshots so we'd need to do that on each build too.

chirino commented 7 years ago

I wouldn't do snapshot deploys as part of CI builds. It's just nice to have an option for a developer to push snapshot build to the repo in case he needs to use it in another project and avoid waiting for the release to get cut. This is definitely in the special case territory.

rhuss commented 7 years ago

I think publishing of snapshots should never be an issue, only consuming it is a problem. I'm fine if people consume stuff temporarily without releasing snapshot dependencies. But that is checked during a release anyway.

I just see this as a kind of 'scratch pad'. And CI shouldn't publish snapshots.

rhuss commented 7 years ago

retest this please

pure-bot[bot] commented 7 years ago

Pull request approved by @KurtStam - applying approved label