search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

Improving handling of Oauth exceptions #709

Closed KurtStam closed 7 years ago

KurtStam commented 7 years ago

Best effort parsing of the raw error message, with a fallback of sending the raw message. This message is set in the userMsgDetail.

https://github.com/syndesisio/syndesis-rest/issues/679 https://github.com/syndesisio/syndesis-rest/issues/652

Let's simply add more parsers as they different raw formats are found.

jimmibot commented 7 years ago

@KurtStam, thanks! @KurtStam, please review this.

KurtStam commented 7 years ago

retest this please

KurtStam commented 7 years ago

retest this please

zregvart commented 7 years ago

Hey @KurtStam I PR'd your PR see https://github.com/KurtStam/syndesis-rest/pull/1 😄 seemed easier that leaving a bunch of review comments here

rhuss commented 7 years ago

Good we get the PR in asap ? I plan to go TP2 maybe already today ...

zregvart commented 7 years ago

Good we get the PR in asap ? I plan to go TP2 maybe already today ...

Let's give @KurtStam a chance to review my comments via code PR, as is it is good to go and we could address those bits in another PR after if we're in a hurry.

KurtStam commented 7 years ago

@zregvart I reviewed and merged. It's in my branch but this PR is not updating..

KurtStam commented 7 years ago

retest this please

pure-bot[bot] commented 7 years ago

Pull request approved by @zregvart - applying approved label

chirino commented 7 years ago

Manual merging since this is just waiting for Jenkins CI and that seems a little broken at the moment.