search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

Fixing invalid swagger link issues #382 #731

Closed KurtStam closed 7 years ago

KurtStam commented 7 years ago

382 red icon on README.md and https://github.com/syndesisio/syndesis-rest/issues/646

Issue 1 is that circle-ci changed the api to their build artifacts: https://circleci.com/docs/2.0/artifacts/#downloading-all-artifacts-for-a-build-on-circleci So we can no longer have a direct link to the swagger.json on circle-ci. Only a link to a document with links: https://circleci.com/api/v1.1/project/github/syndesisio/syndesis-rest/latest/artifacts. Next best thing seems to use the link to staging.

Issue 2 our swagger.json is not valid as it is missing a title attribute, causing the red error icon.

{"messages":["attribute info.title is missing"],"schemaValidationMessages":[{"level":"error","domain":"validation","keyword":"required","message":"object has missing required properties ([\"title\"])","schema":{"loadingURI":"http://swagger.io/v2/schema.json#","pointer":"/definitions/info"},"instance":{"pointer":"/info"}}]}

so I added a title attribute.

jimmibot commented 7 years ago

@KurtStam, thanks! @KurtStam, please review this.

pure-bot[bot] commented 7 years ago

Pull request approved by @rhuss - applying approved label