fix: set the username as the label when creatin...

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.

https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/

Apache License 2.0

6 stars 17 forks source link

fix: set the username as the label when creatin... #771

Closed zregvart closed 6 years ago

zregvart commented 6 years ago

...g integration deployment

Username that we use to count the number of deployments was set as annotation and when counting expected as label. This sets the username as label when creating integration deployment.

Fixes #769

jimmibot commented 6 years ago

@zregvart, thanks! @KurtStam, please review this.

dsimansk commented 6 years ago

I'd prefer label with prefix like syndesis.io. I might be too picky though :)

https://github.com/syndesisio/syndesis-rest/blob/bfea32ff70468911d4b7ebc3c8b29d934f8e7d6d/openshift/src/main/java/io/syndesis/openshift/OpenShiftService.java#L28-L29

pure-bot[bot] commented 6 years ago

Pull request approved by @rhuss - applying approved label