Make sure that we have replica controllers when integration pod is activated

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.

https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/

Apache License 2.0

6 stars 17 forks source link

Make sure that we have replica controllers when integration pod is activated #784

Closed zregvart closed 6 years ago

zregvart commented 7 years ago

I've just had a restart of the rest pod as it submitted a build to openshift, after the restart build has finished and there was replica controller:

An error occurred while starting the deployment. Reason: replicationcontrollers "tw2sf-2" not found

When reworking the integration lifecycle we should make sure to check if a any definition is missing and recreate it if it is.

jimmidyson commented 7 years ago

We create deploymentconfigs, not replication controllers, and rely on openshift to do what's necessary to create running pods. We should be able to check the deployment for info on why RCs aren't created/updated, but we shouldn't be creating RCs ourselves.