syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

fix: Remove tomcat dependency. #786

Closed chirino closed 7 years ago

jimmibot commented 7 years ago

@chirino, thanks! @KurtStam, please review this.

KurtStam commented 7 years ago

retest this please

chirino commented 7 years ago

@KurtStam the error is not intermittent. The failure:

[INFO] --- dependency-management-maven-plugin:0.7:analyze (default) @ runtime ---
[WARNING] Exclusions must be removed for managed dependency org.springframework.boot:spring-boot-starter-jdbc:jar

Is due to a doggy rule in the dependency-management-maven-plugin in my opinion. The BOM managed dependency is defined in the spring boot BOM which is released and we can't change. Should we just disable this plugin from running. Seems like it leads to more trouble than what it helps to solve.

pure-bot[bot] commented 7 years ago

Pull request approved by @zregvart - applying approved label