search

syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis.io/
14 stars 28 forks source link

OAuth Application Management page title is inconsistent with title in breadcrumb #1099

Open TovaCohen opened 7 years ago

TovaCohen commented 7 years ago

I'm working through the official TP1 release and I noticed that the Settings page has "OAuth Client Management" in the breadcrumbs but "OAuth Application Management" in the title. I think these need to be the same. Or maybe the breadcrumbs could be removed from this page until there is some value they would add. Right now, they don't add value. I understand we're trying to build a foundation for adding features so I probably just don't know the long-term plan, which likely has a reason for why the breadcrumbs are here now. Here's a screen capture: oauth-client-vs-application-management

dongniwang commented 7 years ago

@TovaCohen If you're referring to "My Account" and "OAuth Client Management", those are tabs. It would be good if we refer to it as a tab in documentation. And I believe we removed the tab "My Account" in the UI already ( @kahboom , please confirm. )

I'm not aware of the change from "Client" to "Application". But regardless, we should make it consistent.

As for breadcrumb, we do have breadcrumb in place in the rest of the application. This is a breadcrumb: image

cc: @gashcrumb @kahboom

TovaCohen commented 7 years ago

Ahh, thanks Dongni, good to know those are tabs. I vote for "OAuth Application Management" rather than "OAuth Client Management". The term "Client" invites confusion because a case could be made either way, that is, either ipass is the client or the various applications are the clients. Since the user sees, essentially, a list of applications, I think "OAuth Application Management" is the better title for this page.

gashcrumb commented 7 years ago

So sounds like we've reached a decision here to rename the breadcrumb, great! I'll take off the uxd label and add a bug label along with a priority, that way we know this ready for implementation.