search

syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis.io/
14 stars 28 forks source link

ng-bootstrap only works with bootstrap 4 #136

Closed gashcrumb closed 7 years ago

gashcrumb commented 7 years ago

So just started using the tabs from ng-bootstrap and they don't look like tabs really. Should we move to bootstrap 4? Wonder, how awful is that going to work with patternfly?

gashcrumb commented 7 years ago

Or should we use a bootstrap 3.x compatible set of angular 2 directives is the other question... Or I guess the next option is just add the necessary CSS to make the ng-bootstrap components look as they should.

jimmidyson commented 7 years ago

Can't we just use patternfly markup? Really want to avoid having to play with CSS as much as we can & hoping that patternfly styles are enough...

gashcrumb commented 7 years ago

In this case I want to use this kind of markup:

<ngb-tabset>
        <ngb-tab title="from scratch">
          <template ngbTabContent>
             Content here..
          </template>
        </ngb-tab>
        <ngb-tab title="from template">
          <template ngbTabContent>
            Moar content
          </template>
        </ngb-tab>
</ngb-tabset>

which is from ng-bootstrap. Or we can look into moving to patternfly 4.x and use their refactored components. Maybe that'd be the best way to go, I guess they've an example.

gashcrumb commented 7 years ago

Lemme just have a poke at using patternfly 4.x beta with their components, we'd gain a lot if we could use those given most designs generally make use of those.

gashcrumb commented 7 years ago

Hmm, actually angular-patternfly itself doesn't provide tabs anyways. What we need to do is replace ng-bootstrap with a dependency that uses bootstrap 3, as ng-bootstrap requires bootstrap 4.

Following this quickstart for using angular-patternfly, so far so good, I haven't seemed to have broken the ipaas app. Yet.

gashcrumb commented 7 years ago

Nope, UpgradeAdapter eventually bombs out with a massive stack trace that hangs the developer console, so that's out I think. Will look at finding a replacement for ng-bootstrap.

gashcrumb commented 7 years ago

Trying ng2-bootstrap, also am updating our patternfly dep as well anyways.

kahboom commented 7 years ago

Can this be closed out already?

gashcrumb commented 7 years ago

oh yes, this is all set, sorry!

kahboom commented 7 years ago

No worries! Thanks :)