syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis.io/
14 stars 28 forks source link

align usage of <button> and <a class="button"> #245

Closed jludvice closed 7 years ago

jludvice commented 7 years ago

We use multiple ways of specyfiing buttons. For instance here it's <a [routerLink]=" ['/integrations/create'] " class='btn btn-primary https://github.com/redhat-ipaas/ipaas-ui/blob/f8b8fd9bff62a5576c21b35e34ebcc96ff6cf514/src/app/dashboard/emptystate.component.html#L13

and here it's <button class="btn btn-default" (click)="cancel()">Cancel</button>

I wote for using button because

I wouldn't mind to open PR as an excercise if you @gashcrumb @kahboom agree with this alignment

gashcrumb commented 7 years ago

@jludvice yeah, if you've time to do a PR that's absolutely welcome :-) Thanks!

jludvice commented 7 years ago

Opened PR #247

gashcrumb commented 7 years ago

ooh, this was merged, closing :-)

jludvice commented 7 years ago

Reopening to align integration edit page (PR #320)

jludvice commented 7 years ago

PR #320 merged. Closing issue.