syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis.io/
14 stars 28 forks source link

When connector has no config, unable to view action in integration editor #420

Closed kcbabo closed 7 years ago

kcbabo commented 7 years ago

After I've set a start/finish connection in the integration editor and selected an action, the UI moves on to other steps. If I go back to the connection, I can't see which action is used. I think this might have changed when we decided to skip config page when an action had no config parameters.

kcbabo commented 7 years ago

I just need to be able to see which action is used on a connection even if it has no config.

gashcrumb commented 7 years ago

Yeah, I mean the only way you'd see the action is via that config page even if it's empty.

Unless we add the action name to the connection name in the side-bar but that's gonna get terrible looking the moment you pick 'Salesforce Example - Create/Update Contact'

Maybe instead of skipping the config page we just show some text like No configuration is needed for this action and then keep the page. @sjcox-rh @dongniwang ?

kcbabo commented 7 years ago

Yeah, we need to be a bit creative here. I think it would be cool if there was a separate header or something on the config page which had the action name. Config would be below that. Header would always be present when clicking on a connection. Config would only be shown if the action has configuration.

gashcrumb commented 7 years ago

Okay, so I can break up the <h1> tag, so instead of (for example) Configure HTTP GET it's just HTTP GET and then below that we have the configuration section or a note that there's no config necessary.

gashcrumb commented 7 years ago

Linked PR makes this happen instead -> screencapture-localhost-4200-integrations-create-action-configure-1-1492010603249

kcbabo commented 7 years ago

Perfect!

On Wed, Apr 12, 2017 at 11:23 AM, Stan Lewis notifications@github.com wrote:

Linked PR makes this happen instead -> [image: screencapture-localhost-4200-integrations-create-action-configure-1-1492010603249] https://cloud.githubusercontent.com/assets/351660/24965589/7d147ec0-1f72-11e7-99b6-0856b574755d.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/redhat-ipaas/ipaas-ui/issues/420#issuecomment-293613478, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUzZYkqS9JirsTgEpWURVm8eqVJf8Zfks5rvOyJgaJpZM4M7f66 .

kcbabo commented 7 years ago

OK, there's a couple tweaks I'd like to make here. This change now means I have to click Next again if there's no configuration, which I would prefer not to do. Also, if I click on a connection to see the action configuration, I have to click next to get out of the view before doing something else in the UI (e.g. adding a step).

Can I have the best of both worlds? :-)

gashcrumb commented 7 years ago

We could maybe add the action underneath the connection name in the sidebar on a second line? Then it'd be possible to skip that page...

On Apr 12, 2017 6:25 PM, "Keith Babo" notifications@github.com wrote:

OK, there's a couple tweaks I'd like to make here. This change now means I have to click Next again if there's no configuration, which I would prefer not to do. Also, if I click on a connection to see the action configuration, I have to click next to get out of the view before doing something else in the UI (e.g. adding a step).

Can I have the best of both worlds? :-)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/redhat-ipaas/ipaas-ui/issues/420#issuecomment-293724831, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVdrEEIeHG8o77CQi8QUSOW7j-n-SNCks5rvU9hgaJpZM4M7f66 .

gashcrumb commented 7 years ago

I tried just kinda sticking the action name underneath the connection name but it looked kinda busy. What about using the action name in the integration instead, for example:

screencapture-localhost-4200-integrations-edit-2-save-or-add-step-1492102210067

or maybe a better example:

screencapture-localhost-4200-integrations-edit-1-save-or-add-step-1492102313700

gashcrumb commented 7 years ago

K, lemme know how that goes, @sjcox-rh might need to ponder this one longer term.

kahboom commented 7 years ago

What the hell... the skinny donut is back again?? But how? I just fixed it lol. Guess only for a single step. Will have to take a look at that when I get back later.

kahboom commented 7 years ago

@gashcrumb - This was reopened, is it not complete?

gashcrumb commented 7 years ago

Yeah, I think we can close this now