search

syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis.io/
14 stars 28 forks source link

Missing Connector Icons: ServiceNow & Messaging #453

Closed kahboom closed 7 years ago

kahboom commented 7 years ago

In the Connections List view, the icons for Messaging and ServiceNow are missing. Broken link image is shown instead.

cc @sjcox-rh @dongniwang - I see that we have the Messaging icon, so there must be something wrong with the image icon path that I'll check on now, but I don't see a ServiceNow icon in the repository. Do we have one? Also, please verify that this is the correct Messaging icon:

messaging connection

Thanks in advance! :purple_heart:

Reference

kahboom commented 7 years ago

The issue with the Messaging icon is that the connector name string is actually jms, so the image icon path doesn't match the connector name (it is looking for /assets/icons/jms.connection.png, for instance). We can filter this in the UI and check if 'jms' then render the 'messaging' icon type of thing, but I gather this is not the best practice, as we should be consistent. So, we are left with 2-3 options:

  1. Have the API change the string of text to 'messaging' instead of 'jms'.
  2. Provide two separate icons and connectors, one for 'messaging' and another for 'jms'. These seems better to me as we shouldn't assume all 'messaging' is equal to 'jms'; they are not mutually exclusive.
  3. Duplicate the icons across services. I personally think connector names and the icons should be specific to one another. If everyone disagrees (such as in the case of jms and messaging using the same icon), we can duplicate the image icon and just name it to whatever we need (ie duplicate the messaging.png icon and rename as jms.png so we have the same icon for both without needing to do a check in the UI).

In the case of 2, we'd obviously need a second icon from UXD.

cc'ing @jimmidyson @chirino @rhuss @KurtStam @gashcrumb and whoever else is interested in discussing this. :)

sjcox-rh commented 7 years ago

@kahboom @dongniwang Yup that's the correct messaging icon! I haven't provided a ServiceNow icon but I can do that, will send that over shortly.

Are there any other icons that are missing? If so let me know. Actually, do we have a comprehensive list of all connectors we plan on using for summit? That way I can just check them off as I provide them :]

Thanks!

kahboom commented 7 years ago

@sjcox-rh - Thanks! So, I believe @kcbabo has listed them in this doc, but maybe he can chime and verify.

So, in that case I'll just go with solution 3 until we can decide to go with 1, 2, or a better solution (I believe everyone in Europe is still on holiday until tomorrow).

kahboom commented 7 years ago

@sjcox-rh - That also means that we may end up needing a separate icon for JMS, not sure yet though, we'll see what the rest of the team says.

sjcox-rh commented 7 years ago

@kahboom I've attached the servicenow icon in the jira story since github doesn't support uploading of svg's :]

https://issues.jboss.org/browse/IPAAS-250

kahboom commented 7 years ago

Thanks @sjcox-rh ! I guess I'll close this issue and we can create one to discuss JMS vs Messaging icons post-Summit.