search

syndesisio / syndesis-verifier

Syndesis Verifier Service
Apache License 2.0
2 stars 8 forks source link

fix: Can't Verify Saleforce Connection (#12) #13

Closed zregvart closed 7 years ago

zregvart commented 7 years ago

Removes the operationName added by SalesforceVerifier to the parameters map. The operationName is not required and I think it should not be added.

Also changes the connector name from salesforce-upsert-contact to just salesforce.

Also creates Camel components without starting them as it is not needed for verifying the component that the component is started.

Assumes:

Does not:

rhuss commented 7 years ago

Thanks a lot for the PR, looks good to me. We need this operation name in some version of Camel when there was a mismatch in the catalog mappings.

Also agree that the base component should be used for the validation. This would also probably solve https://github.com/syndesisio/syndesis-rest/issues/219

I will do the changes for the other connectors, too.

rhuss commented 7 years ago

[merge]

rhuss commented 7 years ago

@zregvart If I changed from component "twitter-mention" to "twitter" then I get an error about a missing kind. Why is this not a problem for "salesforce" ?

rhuss commented 7 years ago

@zregvart I'll stick to twitter-mention for now, as it seems that the component can't be instantiated without specifying the 'action' (which is specified by the connector)