syndesisio / syndesis-verifier

Syndesis Verifier Service
Apache License 2.0
2 stars 8 forks source link

Create connection / validate returns 500 when all fields are empty #15

Closed jludvice closed 7 years ago

jludvice commented 7 years ago

validator-error.png

Request: https://syndesis-qe.b6ff.rh-idev.openshiftapps.com/api/v1/connectors/salesforce/verifier payload

{loginUrl: "https://login.salesforce.com"}

verifier logs:

2017-08-03 08:52:02.194  INFO 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     : PING: salesforce === ERROR
2017-08-03 08:52:02.194 ERROR 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     : salesforce --> 
2017-08-03 08:52:02.209 ERROR 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     :    ILLEGAL_PARAMETER_GROUP_COMBINATION : null
2017-08-03 08:52:02.210 ERROR 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     :    ILLEGAL_PARAMETER_GROUP_COMBINATION : null
2017-08-03 08:52:02.210 ERROR 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     :    ILLEGAL_PARAMETER_GROUP_COMBINATION : null
2017-08-03 08:52:02.210 ERROR 1 --- [  XNIO-3 task-4] i.s.verifier.impl.SalesforceVerifier     :    MISSING_PARAMETER : clientId should be set

I'd expect it to return reasonable message that configuration is not valid.

zregvart commented 7 years ago

I think this was fixed in #7 and #46