search

syndesisio / syndesis.io

The syndesis.io Website
https://syndesis.io
10 stars 33 forks source link

feat: improved start script #145

Closed zregvart closed 4 years ago

zregvart commented 4 years ago

With the releases we now provide a ZIP file containing tools/bin directory within it (syndesis-cli.zip), see[1].

Now this syndesis-cli.zip can be downloaded in lieu of downloading the whole syndesis git repository. By default the latest release is downloaded. Take note that the releases done by daily releases are pre-releases, and not deemed stable. Stable releases are point releases done by explicitly triggering the release build. The latest of these will be available under the latest version.

There's also support for specifying the version via --tag parameter to the start script. This way pre-release versions can be tested.

This refactors the script for easier readability, by splinting functional areas into different functions.

The user experience is improved by providing details on what's being performed.

[1] https://github.com/syndesisio/syndesis/pull/7793

zregvart commented 4 years ago

@KurtStam would be cool if you could have a look at this. Perhaps take it for a spin on OSX.

KurtStam commented 4 years ago

@zregvart I ran it using

./start.sh --vm-driver hyperkit --tag 1.9.1-20200213

So this means we have to add the --tag part in the Quickstart instructions, and update it with every release? Or can we be smarter about finding the newest tag?

zregvart commented 4 years ago

@KurtStam the script can be used without --tag then it picks up the latest release. The latest release according to GitHub is the newest non-preview release. Since we all a 1.9.1-yyyymmdd releases are preview releases the only way to test is to specify the --tag.

KurtStam commented 4 years ago

Let's merge when we release 1.9 so that we can run w/o the --tag and won't have to update the QS instructions.

zregvart commented 4 years ago

Wait to merge when 1.9 is released.

zregvart commented 4 years ago

1.9.0 has just been released, so I merged this.