syndesisio / syndesis.io

The syndesis.io Website
https://syndesis.io
10 stars 36 forks source link

refactor(build): replace uncss with purgecss #207

Closed zregvart closed 3 years ago

zregvart commented 3 years ago

I've noticed the security issues and one of them is with lodash, which we pull in via uncss. gulp-uncss brings in an old version of uncss and is no longer maintained, the recommendation is to use gulp-postcss instead. gulp-postcss seemed too complex for what we're trying to do here. So I opted to use purgecss via gulp-purgecss. The resulting CSS is not as small as the one done with uncss: 57870 (purgecss) vs 45405 (uncss) bytes. But who's splitting hairs, seems to work and we no longer depend on a vulnerable version of lodash.

@kahboom WDYT?