search

syndesisio / syndesis

This project is archived. A flexible, customizable, open source platform that provides core integration capabilities as a service.
https://syndesis.io/
Apache License 2.0
598 stars 202 forks source link

AWS S3 Connector #174

Closed syndesis-bot closed 6 years ago

syndesis-bot commented 7 years ago
@rhuss 2017-10-30

Include aws-s3 connector from syndesis-connectors into Syndesis backend.

syndesis-bot commented 7 years ago
@rhuss 2017-10-30

See https://github.com/syndesisio/connectors/pull/98 for the original PR.

syndesis-bot commented 7 years ago
@oscerd 2017-10-31

I've only updated the title :-)

rhuss commented 6 years ago

@oscerd What else do we need for the connector to work ? Is there UI / UX work required ?

oscerd commented 6 years ago

I guess one thing we need to take into account is how to handle the input and output expected. For example the copy object need a File as input, while the polling bucket action will have a list of S3Object as output..

oscerd commented 6 years ago

We need an icon for AWS S3 connector, we already have the UI (but maybe a review is good) and we need an UX history too

sjcox-rh commented 6 years ago

@oscerd @rhuss I've attached the png icon for AWS-S3. I can't upload SVG, but you can download the svg file here if needed:

https://drive.google.com/a/redhat.com/file/d/1CFtCRThCyL-lP4yjntN9vLrEJnjOPaAK/view?usp=sharing

_ipaas_connectionicons_aws-s3

oscerd commented 6 years ago

Nice! :-)

oscerd commented 6 years ago

Can we add the icon to the ux assets? It would be great to have this in.

tplevko commented 6 years ago

Hi, great job with the S3 connector! There are just a few observations/questions from QE for now:

  1. It would be nice to have the similar connection validation mechanism as for salesforce/twitter when creating connection.
  2. Is it possible to include S3/AWS configuration to the "Settings" page, similar to salesforce/twitter?
  3. The region choice is currently manual, which is quite cumbersome for citizen developer. Would it be possible to include some sort of dropdown menu (or something similar), where all the S3 locations would be included? (This is just a nice to have feature, but would be definitely cool to have it there)
oscerd commented 6 years ago

Hello,

  1. The validation mechanism is already present on the camel side. But it will be available from 2.21.0
  2. I think so. @zregvart wdyt?
  3. I'll investigate about it.
oscerd commented 6 years ago

@syndesisio/ui-api can the S3 icon be added to syndesis UI to be used in the deployment.json file? Thanks.

amysueg commented 6 years ago

To @oscerd 's earlier comment about adding the icon to the UX assets, @sjcox-rh would you be able to add the svg icon to the UX folder, via a PR? Thank you.

dongniwang commented 6 years ago

Just created PR for this.

cc: @amysueg @sjcox-rh @oscerd

oscerd commented 6 years ago

The PR is merge, do @syndesisio/ui-api need to add the icon to be used in the deployment.json? Thanks.

oscerd commented 6 years ago

Now the regions are part of a dropdown menu and I added the validation mechanism to this connector too.