search

syndesisio / syndesis

This project is archived. A flexible, customizable, open source platform that provides core integration capabilities as a service.
https://syndesis.io/
Apache License 2.0
597 stars 203 forks source link

Telegram connection validation missing #2872

Open Stefan365 opened 6 years ago

Stefan365 commented 6 years ago

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

The problem

Telegram connection(from syndesis-extension project) configuration lacks Validation button. see attached picture

Expected behavior

User can validate Authorization Token.

Screenshot

telegram_validate

Request and Response Data

API Endpoints and Schemas

Tasks involved / Steps to Reproduce

  1. Customizations -> Extensions -> Import Extension -> ....syndesis-connector-telegram-1.0.0.jar
  2. Connections -> Create Connection -> Telegram
nicolaferraro commented 6 years ago

There's a technical limitation in syndesis, so that validation is not available to extensions. Until the telegram extension becomes a top level connector, this cannot be added.

gashcrumb commented 6 years ago

Would it be worth creating an issue for that limitation? I guess an extension probably should have some way of handling a request to validate it's connection settings.

nicolaferraro commented 6 years ago

I'm sure there's already at least one. The Meta pod currently can execute only prepackaged code and cannot load classes dynamically.

We've made a exception for jdbc jars, that can be embedded into the meta pod after a restart. But they are "simple" jars.

Allowing each extension to run code in meta can be a issue because they can pollute the classpath and prevent other syndesis code to work.

A solution (for which @lburgazzoli did a POC over a year ago) include dynamically loading code in the meta pod, using classloader isolation. We may also think to "add" another meta pod just for extensions.

But I'm definitely in favor of doing it.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had any activity since 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

tplevko commented 5 years ago

This seems to be still an issue - reopening it.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

nicolaferraro commented 5 years ago

It should be not so difficult to do, let's keep it open

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!