search

syndesisio / syndesis

This project is archived. A flexible, customizable, open source platform that provides core integration capabilities as a service.
https://syndesis.io/
Apache License 2.0
597 stars 204 forks source link

Snapshot camel release 2.21.0.fuse-740028 stops Syndesis build due to google-sheets problem #5663

Closed phantomjinx closed 5 years ago

phantomjinx commented 5 years ago

To incorporate #5533, I upgraded the fuse-camel dependency to the latest released (2.21.0.fuse-740028). Unfortunately, this doesn't build:

[INFO] 
[INFO] --- duplicate-finder-maven-plugin:1.3.0:check (basepom.default) @ connector-google-sheets ---
[INFO] Checking compile classpath
[INFO] Checking runtime classpath
[INFO] Checking test classpath
[WARNING] Found duplicate and different resources in [/home/phantomjinx/programming/java/syndesis/app/connector/google-sheets/target/classes, org.apache.camel:camel-catalog:2.21.0.fuse-740028]:
[WARNING]   org/apache/camel/catalog/components/google-sheets-stream.json
[WARNING]   org/apache/camel/catalog/components/google-sheets.json
[WARNING] Found duplicate classes/resources in compile classpath.
[WARNING] Found duplicate and different resources in [/home/phantomjinx/programming/java/syndesis/app/connector/google-sheets/target/classes, org.apache.camel:camel-catalog:2.21.0.fuse-740028]:
[WARNING]   org/apache/camel/catalog/components/google-sheets-stream.json
[WARNING]   org/apache/camel/catalog/components/google-sheets.json
[WARNING] Found duplicate classes/resources in runtime classpath.
[WARNING] Found duplicate and different resources in [/home/phantomjinx/programming/java/syndesis/app/connector/google-sheets/target/classes, org.apache.camel:camel-catalog:2.21.0.fuse-740028]:
[WARNING]   org/apache/camel/catalog/components/google-sheets-stream.json
[WARNING]   org/apache/camel/catalog/components/google-sheets.json
[WARNING] Found duplicate classes/resources in test classpath.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Connector .......................................... SUCCESS [  5.535 s]
[INFO] Connector :: Support :: Util ....................... SUCCESS [ 19.823 s]
[INFO] Connector :: Support :: Verifier ................... SUCCESS [ 13.945 s]
[INFO] Connector :: Support :: Maven Plugin ............... SUCCESS [ 18.604 s]
[INFO] Connector :: Twitter ............................... SUCCESS [ 10.135 s]
[INFO] Connector :: FTP ................................... SUCCESS [  9.454 s]
[INFO] Connector :: SFTP .................................. SUCCESS [  8.961 s]
[INFO] Connector :: Dropbox ............................... SUCCESS [  9.243 s]
[INFO] Connector :: Support :: Test ....................... SUCCESS [ 11.001 s]
[INFO] Connector :: AWS S3 ................................ SUCCESS [ 18.867 s]
[INFO] Connector :: AWS SNS ............................... SUCCESS [ 10.801 s]
[INFO] Connector :: AWS SQS ............................... SUCCESS [  9.955 s]
[INFO] Connector :: ActiveMQ .............................. SUCCESS [ 32.135 s]
[INFO] Connector :: AMQP .................................. SUCCESS [  9.424 s]
[INFO] Connector :: SQL ................................... SUCCESS [01:33 min]
[INFO] Connector :: MQTT .................................. SUCCESS [  8.336 s]
[INFO] Connector :: Support :: Processor .................. SUCCESS [ 12.357 s]
[INFO] Connector :: HTTP .................................. SUCCESS [ 13.242 s]
[INFO] Connector :: Salesforce ............................ SUCCESS [ 17.667 s]
[INFO] Connector :: Slack ................................. SUCCESS [ 12.159 s]
[INFO] Connector :: Gmail ................................. SUCCESS [  8.752 s]
[INFO] Connector :: Timer ................................. SUCCESS [  9.621 s]
[INFO] Connector :: ServiceNow ............................ SUCCESS [ 11.003 s]
[INFO] Connector :: Concur ................................ SUCCESS [  4.221 s]
[INFO] Connector :: Kafka ................................. SUCCESS [ 13.379 s]
[INFO] Connector :: FHIR .................................. SUCCESS [ 45.161 s]
[INFO] Connector :: Webhook ............................... SUCCESS [ 12.198 s]
[INFO] Connector :: Log ................................... SUCCESS [  3.824 s]
[INFO] Connector :: Telegram .............................. SUCCESS [  6.855 s]
[INFO] Connector :: IRC ................................... SUCCESS [  7.808 s]
[INFO] Connector :: API Provider .......................... SUCCESS [  7.678 s]
[INFO] Connector :: Google Calendar ....................... SUCCESS [  9.661 s]
[INFO] Connector :: Google Sheets ......................... FAILURE [ 18.398 s]
[INFO] Connector :: Apache Kudu ........................... SKIPPED
[INFO] Connector :: OData ................................. SKIPPED
[INFO] Connector :: Box ................................... SKIPPED
[INFO] Connector :: Flow .................................. SKIPPED
[INFO] Connector :: REST Swagger .......................... SKIPPED
[INFO] Connector :: EMail ................................. SKIPPED
[INFO] Connector :: Knative ............................... SKIPPED
[INFO] Connector :: Support :: Catalog .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:26 min
[INFO] Finished at: 2019-06-10T19:24:08+01:00
[INFO] Final Memory: 237M/702M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.basepom.maven:duplicate-finder-maven-plugin:1.3.0:check (basepom.default) on project connector-google-sheets: Found duplicate classes/resources! -> [Help 1]

Given this seems to come from the google-sheets dependency in fuse-camel, this will need to be fixed upstream?

oscerd commented 5 years ago

There is the component from Google sheets in that version. Christoph needs to remove the camel bits from the connector and use the component coming from fuse-camel.

oscerd commented 5 years ago

So you need to wait.

oscerd commented 5 years ago

@christophd can you have a look?

christophd commented 5 years ago

@oscerd yep, I am going to tackle this right now

christophd commented 5 years ago

@phantomjinx I have fixed the google-sheets component backport related dependencies in a separate branch on my fork:

https://github.com/christophd/syndesis/tree/issue/5444/use-fuse-google-sheets

It all comes down to this commit:

https://github.com/christophd/syndesis/commit/be47fc4af6ed29448e655aa60ec9f0218ab53528

If you apply these changes to your branch it will work for google-sheets component with 2.21.0.fuse-740028.

I think the best way to incorporate this is to pull my changes to your local branch and have it done in one single PR to Syndesis master in combination with your OData changes.

phantomjinx commented 5 years ago

PR created but with caveat of Deployment tests failing. Not sure why the upgrade should cause these test failures.

mastepan commented 5 years ago

closing as ignore/qe label added