Closed dsimansk closed 6 years ago
Looking at the s2i image, it doesn't look like the jars are present, only POMs:
$ ls /tmp/artifacts/m2/org/springframework/boot/spring-boot-dependencies/1.5.8.RELEASE/
_remote.repositories spring-boot-dependencies-1.5.8.RELEASE.pom spring-boot-dependencies-1.5.8.RELEASE.pom.sha1
Wait that was a stupid thing because it's a POM only module...
JARs are loaded properly. Doesn't seem to be using the local repository at all for some reason.
Don't we copy only syndesis artifacts into the S2I image?
It would seem not (scroll through contents)...
@zregvart Actually this script is only half of the truth.
The rest if copied by a 'syndesis-builder-image-generator.jar' (i.e. https://github.com/syndesisio/syndesis/blob/a7231cb39506a2a186d68db34189c388b8c066a4/app/rest/syndesis-builder-image-generator/src/main/java/io/syndesis/image/Application.java) which creates a synthethic integration with all connectors found in deployment.json, and collects its dependencies (that's how I understood it).
Not really sure whether I like this sort of dependencies, but that best one currently to get snapshot connectors to the S2I build without publishing it to a Maven repo.
Actually,
hi @rhuss . you were checking issues with locally available artifacts today. can this issue be closed in the context of your recent verification?
Yes, when we fix the pom.xml generation (in favor of including the settings.xml)
I think with the changes @nicolaferraro did in #2206 this is no longer an issue.
See the s2i build log for
Twitter -> Salesforce
.@chirino @jimmidyson is syndesis-s2i image still generated properly?