search

syndicate-storage / syndicate-core

Scalable Software-define Storage System
Apache License 2.0
4 stars 1 forks source link

Wrong MS URL creation for syndiate registration #37

Closed iychoi closed 7 years ago

iychoi commented 7 years ago

i.e. if syndicate-ms-datasets-prod.appspot.com/ is given as MS URL, this will create a URL syndicate-ms-datasets-prod.appspot.com/:80 which is wrong.

This doesn't cause actuall HTTP communication to MS since HTTP libraries can handle this. But local file, under .syndicate/ will have different filename causing failure.

163615.706448710 24383:00007fdf9600c780: [     storage.cpp:0324] md_syndicate_pubkey_load: ERROR: md_load_file('/users/rickmcg/.syndicate/syndicate//syndicate-ms-datasets-prod.appspot.com/:80.pub') rc = -2
163615.706528184 24383:00007fdf9600c780: [libsyndicate.cpp:0246] md_certs_reload: ERROR: md_syndicate_pubkey_load('/users/rickmcg/.syndicate/syndicate//syndicate-ms-datasets-prod.appspot.com/:80') rc = -2
iychoi commented 7 years ago

Even when I give a MS URL with ending "/", it worked.

syndicate -d --trust_public_key setup jcnelson@cs.princeton.edu ./jcnelson@cs.princeton.edu.pkey http://syndicate-ms-datasets-prod.appspot.com/