syndicate-storage / syndicate

Internet-scale software-defined storage system
Apache License 2.0
56 stars 10 forks source link

Manifest last-modification time should not change on setxattr() and utime() #78

Closed jcnelson closed 10 years ago

jcnelson commented 10 years ago

We'll need to track a manifest last-mod time separate from the fs_entry structure. This manifest last-mod time should change only when the manifest changes, and on replication, this last-mod time gets used to generate the manifest replica name and URL.

Currently, the fs_entry last-mod time is also the manifest last-mod time. However, the MS needs to change this whenever the associated MSEntry structure gets updated, so it can select the latest MSEntryShard. This includes changing the file's xattrs.

Moreover, if the user calls utime(), the fs_entry last-mod and manifest last-mod times should NOT be altered, since they are used by the MS to return the latest data.

jcnelson commented 10 years ago

This is fixed in my tree, but I haven't committed it yet.

jcnelson commented 10 years ago

Should be fixed as of ec9cb6c413b7c84751cb588f4fb7e8bc35a7d857