synergy-design-system / synergy-design-system

Monorepo for the Synergy Design System.

https://synergy-design-system.github.io/

MIT License

18 stars 1 forks source link

chore: 🔧 chromatic failed detecting regressions #677

Open klaarseSICKAG opened 2 hours ago

klaarseSICKAG commented 2 hours ago

Description

A visual change in syn-alert was ignored by Chromatic which lead to a bug. This happened when updating from Shoelace 2.16.x -> 2.17.x (https://github.com/synergy-design-system/synergy-design-system/pull/641)

Rationale

We have to check what the root cause of the "false negative" is and how this can be avoided in future.

[ ] check root cause
[ ] check if its possible to adapt pixel threshold (if this is really the root cause)
[ ] check if it is meaningful to go from percentage to an absolute threshold value
[ ] keep the balance between false positives and false negative
[ ] check if there are other regressions that might have been overlooked

klaarseSICKAG commented 2 hours ago

refers to #607