synesthesiam / hassio-addons

My Hass.IO add-ons
43 stars 18 forks source link

Pinned Rhasspy 2.5.5 and remove redundant addons. #16

Closed Romkabouter closed 3 years ago

Romkabouter commented 3 years ago

I have pinned Rhasspy 2.5.5 to the addon version. Also, I have removed snowboy and mycroft addons, they are build into Rhasspy.

Feel free to revert the removal of the addons. I also wanted to remove the 2.4 addon but left is out of this PR. Any opinions on it?

synesthesiam commented 3 years ago

Pinning the version is a good idea. I forgot to do this.

I agree too that the other add-ons should go away. I don't know what to do about 2.4 yet. Maybe I should just move 2.5 stuff over the top of it and delete rhasspy25?

Romkabouter commented 3 years ago

Good idea, but we should be careful about breaking stuff for users. I suggest first remove 2.4 as well. We can keep rhasspy25 as long as it is 2.5. Whenever we upgrade rhasspy, we can recreate a rhasspy addon, with the latest version. At the same time we pin the addon version to the rhasspy version